feat(swarm): improve PeerAddresses configurability
#5574
+83
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormshield-frb
force-pushed
the
feat/identify-make-peer-cache-configurable
branch
3 times, most recently
from
8fbd19b
to
be31d42
Compare
stormshield-frb
force-pushed
the
feat/identify-make-peer-cache-configurable
branch
from
be31d42
to
e5435fc
Compare
dariusc93
reviewed
Sep 5, 2024
|
This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏 |
stormshield-frb
force-pushed
the
feat/identify-make-peer-cache-configurable
branch
from
14c1974
to
4d17c21
Compare
stormshield-frb
force-pushed
the
feat/identify-make-peer-cache-configurable
branch
from
1b14122
to
457c063
Compare
|
This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏 |
jxs
approved these changes
Nov 5, 2024
4 tasks
|
This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our average peer has over 10 advertised addresses. Doing so,
identifywas continuously (every 1 minute) emittingToSwarm::NewExternalAddrOfPeerwhich was overflowing our logs and was making thePeerCachekind of useless.For this reason, we made some changes in order to be able to configure the number of addresses that should be cached for a peer. We are upstreaming this changes.
Notes & open questions
N/A
Change checklist