Implement wat-numeric-values proposal #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposal adds support to the text format for numeric data values,
e.g.:
```
(data
(i32 1 2 3 4)
(f32 1.0 1.5))
```
The current proposal doesn't specify how SIMD values would be encoded,
so this implementation uses this syntax:
```
(data
(v128
i32x4 0 0 0 0
f64x2 1.0 1.5))
```
sbc100
approved these changes
Nov 16, 2020
| @@ -625,7 +661,7 @@ struct Memory { | |||
| MemoryDesc desc; | |||
| OptAt<InlineImport> import; | |||
| InlineExportList exports; | |||
| optional<TextList> data; | |||
| optional<DataItemList> data; | |||
There was a problem hiding this comment.
Why not just use the empty list here to signify no items?
There was a problem hiding this comment.
I've been trying to use optional for things like this, rather than sentinel values. It makes it nicer to do a quick "does this exist" check too (data.has_value()) -- otherwise you'd probably need a separate function.
|
FYI: @echamudi |
|
@binji Thanks for the implementation. The v128 syntax looks good to me! I'll incorporate it in the proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal adds support to the text format for numeric data values,
e.g.:
The current proposal doesn't specify how SIMD values would be encoded,
so this implementation uses this syntax: