Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about improper RFC2119 usage, and about example without id #147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn about improper RFC2119 usage, and about example without id #147

wants to merge 1 commit into from

Conversation

padenot
Copy link
Member

@padenot padenot commented Feb 28, 2025 •
edited by pr-preview bot
Loading

Best used with the Makefile in #146, because that calls bikeshed with the right options.

Preview | Diff

@padenot padenot requested review from evanbliu and hoch February 28, 2025 15:09
hoch
hoch approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoch hoch hoch approved these changes

@evanbliu evanbliu Awaiting requested review from evanbliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@padenot @hoch