Fix form macro with nette/application ≥ 3.2.2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The form is created using the `control` macro and we are going to add one using the `form` macro.
Since nette/application@1aba9da, `TemplateFactory` no longer registers the `FormsExtension`, which caused the `form` macro to be missing. Let’s re-add it in our `LatteFactory`. The `CacheExtension`, which was also removed, is not necessary or even detrimental for tests so we are going to ignore it. With older `nette/application` versions, the `FormsExtension` will be added a second time so the macros from the first registration will be shadowed but that does not matter since it is the same extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since nette/application@1aba9da (a side effect of nette/application#320),
TemplateFactoryno longer registers theFormsExtension, which caused theformmacro to be missing.Let’s re-add it in our
LatteFactory.The
CacheExtension, which was also removed, is not necessary or even detrimental for tests so we are going to ignore it.With older
nette/applicationversions, theFormsExtensionwill be added a second time so the macros from the first registration will be shadowed but that does not matter since it is the same extension.