Skip to content

Several minor bugs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raven2cz opened this issue Jul 11, 2022 · 4 comments · Fixed by #13
Closed

Several minor bugs #12

raven2cz opened this issue Jul 11, 2022 · 4 comments · Fixed by #13

Comments

@raven2cz
Copy link

raven2cz commented Jul 11, 2022

First, NICE work! Thanks for this trick.

I tested your release and found several problems (maybe bugs). This is my tested element:

<code-input id="httpHeadersCodeInput" style="font-size: large; resize: vertical; overflow: auto; height: 400px; width: 100%;"
                          lang="HTTP" placeholder="Type HTTP HEADERS here" template="syntax-highlighted" onchange="httpHeadersOnChange(this.value);"
                          value="Accept-Charset: utf-8"</code-input>

There are a list of them which I found:

  • placeholder is not shown. I tried to remove value param, but the placeholder is not shown in text area.
  • function onchange is not called, no action for this function. I tried to test oninput which works. Maybe change your documentation guide?
  • In some environments, like bootstrap, the triangle for resizing of area is outside of rendered code rectangle. In addition, it seems that much more space is defined outside. Maybe some wrong calculation between text area and code area. Screenshot attached
    image
  • Default font is very large, around extra-large or higher. It is not common approach, I have to use font-size: large for standard font size. This is a strange behavior.
@WebCoder49
Copy link
Owner

Thank you for mentioning these - I will start to fix them now.

@WebCoder49
Copy link
Owner

Does this work with bootstrap for you?
45a8ed9

@WebCoder49 WebCoder49 linked a pull request Jul 15, 2022 that will close this issue
@raven2cz
Copy link
Author

Does this work with bootstrap for you? 45a8ed9

Works! Thanks for all corrections. Can you release it and provide it by cdn.jsdelivr.net? Thx!

@WebCoder49
Copy link
Owner

Yes; this is release 1.1.1:

<script src="https://cdn.jsdelivr.net/gh/WebCoder49/code-input@1.1/code-input.js"></script>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/gh/WebCoder49/code-input@1.1/code-input.css">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants