-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
area:coreA bug/feature for the core code-input.js/code-input.css filesA bug/feature for the core code-input.js/code-input.css filesbreaking-changebugSomething isn't workingSomething isn't workingpriority:medium
Milestone
Description
What should scroll - the textarea and pre code or the code-input element?
Currently, code-input scrolls but with a blur/focus each time a character is entered, to fix bug #93 but causing bugs #115, #117, #124.
| What scrolls | code-input (but no blur/focus) |
textarea and pre code |
|---|---|---|
| Branch | code-input-scrolls-but-no-blur-focus | let-textareas-do-their-job |
| Previously seen in | v2.2-v2.5 (sorry for the potential breaking change; I respect Semantic Versioning better now) | v1.0-v2.1 |
| Breaking change? | No | Yes (changes CSS, e.g. #88) |
| #93 | Broken 😢 | Fixed |
| #115 | Fixed | Fixed |
| #117 | Fixed | Fixed |
| #124 | Probably fixed | Probably fixed |
| #127 | Broken (not fixable at this level) | Broken (not fixable at this level) |
| #88 | Would require plugin/JS 😢 | Implemented logically via CSS |
The Result
Because it's a breaking change, this looks like we're going to need a new major version v3, and have the textarea and pre code scroll.
Metadata
Metadata
Assignees
Labels
area:coreA bug/feature for the core code-input.js/code-input.css filesA bug/feature for the core code-input.js/code-input.css filesbreaking-changebugSomething isn't workingSomething isn't workingpriority:medium