handle object type listeners #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this! I will review, merge and release it within a week. Sorry - that wasn't true. I was busier than I thought. |
|
This has been tested both on Firefox+X11+Ubuntu and Chrome Mobile+Android. |
|
@keithjgrant, I have released this in version 2.3.1. Thank you for the suggestion! I have noticed I am quite prone to setting unrealistically early targets for myself like I did here and have done in various contexts before. I will mention this publicly here as a way to remind me in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MDN the function signature for
addEventListenershould support a listener that is a function, or an object with ahandleEvent()method, or null.Currently only functions are supported. This makes it so I cannot use
<code-input>inside a Lit component (it throws a "not a function" error), as Lit passes in an object.These changes update the
addEventListeneroverride to support all three types.