Skip to content

Make selectionchange work with popup; Add selectionStart parameter to popup callback #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Make selectionchange work with popup; Add selectionStart parameter to popup callback #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code-input.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ export namespace plugins {
class Autocomplete extends Plugin {
/**
* Pass in a function to create a plugin that displays the popup that takes in (popup element, textarea, textarea.selectionEnd).
* @param {(popupElement: HTMLElement, textarea: HTMLTextAreaElement, selectionEnd: number) => void} updatePopupCallback a function to display the popup that takes in (popup element, textarea, textarea.selectionEnd).
* @param {(popupElement: HTMLElement, textarea: HTMLTextAreaElement, selectionEnd: number, selectionStart?: number) => void} updatePopupCallback a function to display the popup that takes in (popup element, textarea, textarea.selectionEnd).
*/
constructor(updatePopupCallback: (popupElem: HTMLElement, textarea: HTMLTextAreaElement, selectionEnd: number) => void);
constructor(updatePopupCallback: (popupElem: HTMLElement, textarea: HTMLTextAreaElement, selectionEnd: number, selectionStart?: number) => void);
}

/**
Expand Down
6 changes: 3 additions & 3 deletions plugins/autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ codeInput.plugins.Autocomplete = class extends codeInput.Plugin {
popupElem.style.left = caretCoords.left + "px";

if(!onlyScrolled) {
this.updatePopupCallback(popupElem, textarea, textarea.selectionEnd);
this.updatePopupCallback(popupElem, textarea, textarea.selectionEnd, textarea.selectionStart);
}
}
/* Create the popup element */
Expand All @@ -45,7 +45,7 @@ codeInput.plugins.Autocomplete = class extends codeInput.Plugin {

let textarea = codeInput.textareaElement;
textarea.addEventListener("input", () => { this.updatePopup(codeInput, false)});
textarea.addEventListener("click", () => { this.updatePopup(codeInput, false)});
textarea.addEventListener("selectionchange", () => { this.updatePopup(codeInput, false)});
}
/**
* Return the coordinates of the caret in a code-input
Expand Down Expand Up @@ -85,4 +85,4 @@ codeInput.plugins.Autocomplete = class extends codeInput.Plugin {
return {"top": afterSpan.offsetTop - textarea.scrollTop, "left": afterSpan.offsetLeft - textarea.scrollLeft};
}
updatePopupCallback = function() {};
}
}
25 changes: 18 additions & 7 deletions tests/tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ function beginTest(isHLJS) {
if(isHLJS) {
codeInput.registerTemplate("code-editor", new codeInput.templates.Hljs(hljs, [
new codeInput.plugins.AutoCloseBrackets(),
new codeInput.plugins.Autocomplete(function(popupElem, textarea, selectionEnd) {
if(textarea.value.substring(selectionEnd-5, selectionEnd) == "popup") {
new codeInput.plugins.Autocomplete(function(popupElem, textarea, selectionEnd, selectionStart) {
if(selectionStart == selectionEnd && textarea.value.substring(selectionEnd-5, selectionEnd) == "popup") {
// Show popup
popupElem.style.display = "block";
popupElem.innerHTML = "Here's your popup!";
Expand All @@ -129,8 +129,8 @@ function beginTest(isHLJS) {
} else {
codeInput.registerTemplate("code-editor", new codeInput.templates.Prism(Prism, [
new codeInput.plugins.AutoCloseBrackets(),
new codeInput.plugins.Autocomplete(function(popupElem, textarea, selectionEnd) {
if(textarea.value.substring(selectionEnd-5, selectionEnd) == "popup") {
new codeInput.plugins.Autocomplete(function(popupElem, textarea, selectionEnd, selectionStart) {
if(selectionStart == selectionEnd && textarea.value.substring(selectionEnd-5, selectionEnd) == "popup") {
// Show popup
popupElem.style.display = "block";
popupElem.innerHTML = "Here's your popup!";
Expand Down Expand Up @@ -343,12 +343,23 @@ console.log("I've got another line!", 2 < 3, "should be true.");

await waitAsync(50); // Wait for popup to be rendered

testAssertion("Autocomplete", "Popup Shows", confirm("Does the autocomplete popup display correctly? (OK=Yes)"), "user-judged");
backspace(textarea);
testAssertion("Autocomplete", "Popup Shows on input", confirm("Does the autocomplete popup display correctly? (OK=Yes)"), "user-judged");
move(textarea, -1);

await waitAsync(50); // Wait for popup disappearance to be rendered

testAssertion("Autocomplete", "Popup Disappears", confirm("Has the popup disappeared? (OK=Yes)"), "user-judged");
testAssertion("Autocomplete", "Popup Disappears on arrow key", confirm("Has the popup disappeared? (OK=Yes)"), "user-judged");
move(textarea, 1);

await waitAsync(50); // Wait for popup to be rendered

testAssertion("Autocomplete", "Popup Shows on arrow key", confirm("Does the autocomplete popup display correctly? (OK=Yes)"), "user-judged");
backspace(textarea);

await waitAsync(50); // Wait for popup disappearance to be rendered

testAssertion("Autocomplete", "Popup Disappears on backspace", confirm("Has the popup disappeared? (OK=Yes)"), "user-judged");
move(textarea, 1);
backspace(textarea);
backspace(textarea);
backspace(textarea);
Expand Down