Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cc 440 comment login signup errors #683

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

tw2113
Copy link
Member

@tw2113 tw2113 commented Sep 9, 2024

This PR protects against empty results for formatted list arrays.

It also touches up some list management in similar ways we do elsewhere for the plugin, as well as some logic touchups and invalid get_option usage.

@tw2113 tw2113 changed the base branch from main to release270 September 9, 2024 23:49
@tw2113
Copy link
Member Author

tw2113 commented Sep 9, 2024

@guzmandrade-wds Just look at includes/class-settings.php https://github.com/WebDevStudios/constant-contact-forms/pull/683/files#diff-ffe4c5eae4f71cfc06cca2fc4501f5eac2646795e3253f4b5d45c3efe226b592

The PR got mixed up a bit with a merge of main branch into release270 branch.

@tw2113 tw2113 added this to the 2.7.0 milestone Sep 11, 2024
@tw2113 tw2113 requested a review from lindseywb October 8, 2024 18:35
Copy link

@lindseywb lindseywb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tw2113 tw2113 force-pushed the fix/CC-440-comment-login-signup-errors branch from a450621 to 402484b Compare October 8, 2024 22:52
@tw2113 tw2113 merged commit ff30665 into release270 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants