Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/#460 slick carousel a11y fixes #478

Closed
wants to merge 15 commits into from

Conversation

Cheffheid
Copy link
Contributor

Doesn't necessarily close a ticket. It does improve the situation for #460.

DESCRIPTION

I've added some additional features to help SlickJS do better at accessible content:

  • A pause button is added to the carousel through JavaScript after it initializes.
  • Made use of wp.a11y.speak() to update an aria-live region with the carousel status, specifically when the pause button is used or when the arrow navigation is used.

The dot navigation didn't need any additions, since it seems to be using a tablist role to provide feedback about the amount of slides there are and what button is activated (eg. "3 of 3").

SCREENSHOTS

No significant styling was added. The pause button will sit in the bottom left, below the slider, by default.

I do have a screenshot of a test carousel and the NVDA speech viewer:
nvda

OTHER

  • Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • Does this pass CBT?

STEPS TO VERIFY

Create a page with a carousel on it and verify that the pause button appears. If you have NVDA or some other screenreader installed, you should be able to use that to test the verbal feedback by clicking/keyboarding the Previous/Next and Pause buttons.

@coreymcollins
Copy link
Contributor

I'm going to put some time into testing some other options to see how accessible they are for our uses, as well as how easy they are to customize to our various needs.

A few I'm looking at:

I'm also in the camp of just not using carousels ever, but I know that's not a reality we live in when building sites for others. The main thing I like about the 3 options above (and I'm sure there are more) is that they're actually maintained, whereas Slick hasn't had an update since last April with 930 outstanding issues and little to no feedback on those issues.

Tiny Slider seems nice as it's the only one of the group above that includes an option for a pause button (that I can find, at least) and mentions accessibility in the Github repo.

@coreymcollins coreymcollins mentioned this pull request Jun 21, 2019
3 tasks
@gregrickaby gregrickaby deleted the branch master October 16, 2020 20:35
@gregrickaby gregrickaby deleted the hotfix/#460-slick-carousel-a11y-fixes branch October 16, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants