Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import to support Tomcat and Jetty newest versions. #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@mayhew64
Copy link
Contributor

How does this affect the dependencies on the embedded container?

@nbaars What happened to these jsp files in the new WebGoat.

@h3xstream
Copy link
Author

I stumble upon this incompatibility because I was precompiling the jsp with Jetty JSPC (latest version). I assume this would be the same error when visiting the page with the latest container.

I do not suspect that removing the semicolon would create any backward compatibility problem. I can see imports that just like this one : https://github.com/WebGoat/WebGoat-Legacy/blob/master/src/main/webapp/reportBug.jsp#L3

I am not sure to understand the question about the new WebGoat .. Are you talking about WebGoat 7?
I did not ran into any problem compiling it as-is.

@h3xstream
Copy link
Author

@mayhew64 Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants