-
Notifications
You must be signed in to change notification settings - Fork 15
Conditionally show sub-times #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Now also updated the console output to include durations:
|
@@ -781,16 +826,36 @@ class Benchmark { | |||
return geomeanScore(subScores); | |||
} | |||
|
|||
get totalTime() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More high-level: Instead of having individual fields for each score and time, including these getters, how about we simply have the {sub,all}{Scores,Times}
objects with simply the keys defining what's available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I have this still pending somwhere... just wanted to get this out with fewer changes.
I might do this as a followup.
This is the view you'll get after pressing

d
or clicking on the score: