Skip to content

Conversation

camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Aug 27, 2025

  • Collect and report subTimes like subScores
  • Only show times if the global .details CSS class is set (the default view is unaffected)
  • Also use .details for displaying displayCategoryScores
  • Change uiFriendlyDuration to only report 2 significant digits
  • Add Benchmark.prototype.wallTime accessor and report that as well

This is the view you'll get after pressing d or clicking on the score:
Screenshot 2025-08-27 at 16 18 03

Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit da7f127
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/68b84f998cec6a000816021e
😎 Deploy Preview https://deploy-preview-167--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni requested a review from kmiller68 August 27, 2025 15:29
@camillobruni camillobruni requested a review from danleh September 3, 2025 07:49
@camillobruni
Copy link
Contributor Author

Now also updated the console output to include durations:

Running babel-minify-wtb:
    First:            32.18   
    Worst:            63.35   
    Average:          92.07   
    Score:            57.26   
    First-Time:      155.35 ms
    Worst-Time:       78.92 ms
    Average-Time:     54.30 ms
    Wall-Time:       973.68 ms
    Total-Time:      288.58 ms

Running acorn-wtb:
    First:            31.00   
    Worst:            30.95   
    Average:          34.69   
    Score:            32.17   
    First-Time:      161.30 ms
    Worst-Time:      161.53 ms
    Average-Time:    144.14 ms
    Wall-Time:      2188.10 ms
    Total-Time:      466.97 ms


First:                48.96   
Worst:                70.11   
Average:              82.78   
First-Time::         102.13 ms
Worst-Time::          71.32 ms
Average-Time::        60.40 ms

Total Score::         65.74   
Total Time::        13608.03 ms

@@ -781,16 +826,36 @@ class Benchmark {
return geomeanScore(subScores);
}

get totalTime() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More high-level: Instead of having individual fields for each score and time, including these getters, how about we simply have the {sub,all}{Scores,Times} objects with simply the keys defining what's available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I have this still pending somwhere... just wanted to get this out with fewer changes.
I might do this as a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants