Add JetStreamParams #171
Open
Add JetStreamParams #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
side-note: once we have this, I can also copy over the dev-menu from speedometer, which makes these parameters a bit more accessible. |
danleh
reviewed
Sep 2, 2025
| console.log(" ", tagName); | ||
| console.log(""); | ||
|
|
||
| if (typeof benchmarksByTag !== "undefined") { |
There was a problem hiding this comment.
Why this check, isn't benchmarksByTag always defined in
Line 2634 in f8e3d7e
In that case, can this just be an assert?
danleh
approved these changes
Sep 3, 2025
| constructor(sourceParams = undefined) { | ||
| if (sourceParams) | ||
| this._copyFromSearchParams(sourceParams); | ||
| if (!this.developerMode) |
There was a problem hiding this comment.
You removed developer mode from the CLI options above, but not here. Is this intended? I'm still not sure I got the intuition behind the developer mode, how is it different / what does it ensure additionally on top of just warning when folks run JetStream with non-default parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For displaying a warning about non-default params we need a way to keep track of what the default values are.
We can reuse the existing code from Speedometer which does exactly that.