Form associated ElementInternals always reports customError when using setValidity #19434

shvaikalesh · 2023-10-23T18:40:06Z

`2b9f4fa`

Form associated ElementInternals always reports customError when using setValidity
https://bugs.webkit.org/show_bug.cgi?id=261432
<rdar://problem/115681066>

Reviewed by NOBODY (OOPS!).

Initial form-associated custom elements implementation attempted to avoid adding a String field by
relying on m_customValidationMessage for both regular [1] and custom [2] validation messages,
which turned out to be incompatible with the implementation of FormListedElement::customError().

Rather than deepening the hack / micro-optimization, this change adds a field and precisely implements
all the spec steps for setValidity() [3].

[1] https://html.spec.whatwg.org/multipage/custom-elements.html#face-validation-message
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#custom-validity-error-message
[3] https://html.spec.whatwg.org/multipage/custom-elements.html#dom-elementinternals-setvalidity

* LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-validation.html:
* Source/WebCore/html/FormAssociatedCustomElement.cpp:
(WebCore::FormAssociatedCustomElement::setValidity):
(WebCore::FormAssociatedCustomElement::validationMessage const):
* Source/WebCore/html/FormAssociatedCustomElement.h:

2b9f4fa

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-23T18:42:11Z

EWS run on previous version of this PR (hash dfa8426)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-24T08:50:49Z

EWS run on previous version of this PR (hash de90c54)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-24T19:33:59Z

EWS run on previous version of this PR (hash 36008ea)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-25T03:01:27Z

EWS run on previous version of this PR (hash 32904d3)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	⏳ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	💥 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

annevk · 2023-12-29T10:24:56Z

I restarted gtk-wk2. @shvaikalesh I suggest we land this if that passes. Seems like a shame to leave this unfixed.

Edit: it seems like this might need to be rebased for the bots to run properly.

webkit-early-warning-system · 2024-01-02T22:52:23Z

EWS run on previous version of this PR (hash 0b5cb42)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	⏳ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	⏳ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	⏳ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2
	✅ 🛠 tv	⏳ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

lukewarlow · 2024-04-12T22:05:28Z

Any chance of getting this rebased? Is a shame to have this (interop) bug in this API.

annevk · 2024-04-13T16:20:44Z

The problem as I understand it is that the gtk-wk2 failure seems real and thus needs investigation by someone(tm).

…g setValidity https://bugs.webkit.org/show_bug.cgi?id=261432 <rdar://problem/115681066> Reviewed by NOBODY (OOPS!). Initial form-associated custom elements implementation attempted to avoid adding a String field by relying on m_customValidationMessage for both regular [1] and custom [2] validation messages, which turned out to be incompatible with the implementation of FormListedElement::customError(). Rather than deepening the hack / micro-optimization, this change adds a field and precisely implements all the spec steps for setValidity() [3]. [1] https://html.spec.whatwg.org/multipage/custom-elements.html#face-validation-message [2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#custom-validity-error-message [3] https://html.spec.whatwg.org/multipage/custom-elements.html#dom-elementinternals-setvalidity * LayoutTests/imported/w3c/web-platform-tests/custom-elements/form-associated/ElementInternals-validation.html: * Source/WebCore/html/FormAssociatedCustomElement.cpp: (WebCore::FormAssociatedCustomElement::setValidity): (WebCore::FormAssociatedCustomElement::validationMessage const): * Source/WebCore/html/FormAssociatedCustomElement.h:

webkit-early-warning-system · 2024-10-10T19:43:22Z

EWS run on current version of this PR (hash 2b9f4fa)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

kyubisation · 2025-03-10T07:14:36Z

Hello everyone
This bug has been fixed in #42134

annevk · 2025-03-10T15:16:27Z

That's great, thanks!

shvaikalesh requested review from cdumez and rniwa as code owners October 23, 2023 18:40

shvaikalesh self-assigned this Oct 23, 2023

shvaikalesh added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Oct 23, 2023

rniwa approved these changes Oct 23, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 23, 2023

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label Oct 24, 2023

shvaikalesh force-pushed the eng/Form-associated-ElementInternals-always-reports-customError-when-using-setValidity branch from dfa8426 to de90c54 Compare October 24, 2023 08:50

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 24, 2023

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label Oct 24, 2023

shvaikalesh force-pushed the eng/Form-associated-ElementInternals-always-reports-customError-when-using-setValidity branch from de90c54 to 36008ea Compare October 24, 2023 19:33

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 24, 2023

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label Oct 25, 2023

shvaikalesh force-pushed the eng/Form-associated-ElementInternals-always-reports-customError-when-using-setValidity branch from 36008ea to 32904d3 Compare October 25, 2023 03:01

shvaikalesh force-pushed the eng/Form-associated-ElementInternals-always-reports-customError-when-using-setValidity branch from 32904d3 to 0b5cb42 Compare January 2, 2024 22:52

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 3, 2024

shvaikalesh removed the merging-blocked Applied to prevent a change from being merged label Oct 10, 2024

shvaikalesh force-pushed the eng/Form-associated-ElementInternals-always-reports-customError-when-using-setValidity branch from 0b5cb42 to 2b9f4fa Compare October 10, 2024 19:43

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 11, 2024

kyubisation mentioned this pull request Mar 8, 2025

Form associated ElementInternals always reports customError when using setValidity #42134

Merged

annevk closed this Mar 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Form associated ElementInternals always reports customError when using setValidity #19434

Form associated ElementInternals always reports customError when using setValidity #19434

shvaikalesh commented Oct 23, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Oct 23, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 24, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 24, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 25, 2023 •

edited

Loading

annevk commented Dec 29, 2023 •

edited

Loading

webkit-early-warning-system commented Jan 2, 2024 •

edited

Loading

lukewarlow commented Apr 12, 2024

annevk commented Apr 13, 2024

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading

kyubisation commented Mar 10, 2025

annevk commented Mar 10, 2025

Form associated ElementInternals always reports customError when using setValidity #19434

Form associated ElementInternals always reports customError when using setValidity #19434

Conversation

shvaikalesh commented Oct 23, 2023 • edited by webkit-early-warning-system Loading

2b9f4fa

webkit-early-warning-system commented Oct 23, 2023 • edited Loading

webkit-early-warning-system commented Oct 24, 2023 • edited Loading

webkit-early-warning-system commented Oct 24, 2023 • edited Loading

webkit-early-warning-system commented Oct 25, 2023 • edited Loading

annevk commented Dec 29, 2023 • edited Loading

webkit-early-warning-system commented Jan 2, 2024 • edited Loading

lukewarlow commented Apr 12, 2024

annevk commented Apr 13, 2024

webkit-early-warning-system commented Oct 10, 2024 • edited Loading

kyubisation commented Mar 10, 2025

annevk commented Mar 10, 2025

shvaikalesh commented Oct 23, 2023 •

edited by webkit-early-warning-system

Loading

`2b9f4fa`

webkit-early-warning-system commented Oct 23, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 24, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 24, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 25, 2023 •

edited

Loading

annevk commented Dec 29, 2023 •

edited

Loading

webkit-early-warning-system commented Jan 2, 2024 •

edited

Loading

webkit-early-warning-system commented Oct 10, 2024 •

edited

Loading