Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CSSRelativeColorSyntaxEnabled preference #2621

Merged

Conversation

@nt1m nt1m self-assigned this Jul 21, 2022
@nt1m nt1m added CSS Cascading Style Sheets implementation WebKit Nightly Build labels Jul 21, 2022
@nt1m nt1m requested a review from weinig July 21, 2022 17:27
@litherum
Copy link
Contributor

Are we sure we are ready for this?

Copy link
Contributor

@litherum litherum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we are.

@darinadler
Copy link
Member

Why hasn’t this been merged?

@nt1m
Copy link
Member Author

nt1m commented Nov 22, 2022

Why hasn’t this been merged?

Two reasons:

@darinadler
Copy link
Member

Makes sense. Maybe we should convert to a draft so it doesn't show up on lists of pending pull requests.

I'm still trying to perfect how I query the list of pull requests that need either review or merging.

@nt1m nt1m marked this pull request as draft November 22, 2022 18:13
@nt1m nt1m marked this pull request as ready for review January 6, 2023 01:24
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 6, 2023
https://bugs.webkit.org/show_bug.cgi?id=242918
rdar://97279447

Reviewed by Sam Weinig and Myles C. Maxfield.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/258519@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258519@main (1890bfb): https://commits.webkit.org/258519@main

Reviewed commits have been landed. Closing PR #2621 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 6, 2023
@webkit-early-warning-system webkit-early-warning-system merged commit 1890bfb into WebKit:main Jan 6, 2023
@nt1m nt1m deleted the relative-color-syntax branch December 12, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants