Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable :dir by default #3907

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Enable :dir by default #3907

merged 1 commit into from
Sep 1, 2022

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Sep 1, 2022 •
edited by webkit-early-warning-system
Loading

e9619fe

Enable :dir by default
https://bugs.webkit.org/show_bug.cgi?id=244663

Reviewed by Antti Koivisto.

Enable :dir since the implementation is complete and we pass all relevant WPT tests.

* LayoutTests/platform/win/TestExpectations:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/254051@main

674f6ca

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@rniwa rniwa self-assigned this Sep 1, 2022
@rniwa rniwa added CSS Cascading Style Sheets implementation WebKit Nightly Build labels Sep 1, 2022
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 1, 2022 •
edited
Loading

674f6ca

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk1 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-mips-tests

@rniwa rniwa requested review from anttijk and smfr September 1, 2022 08:27
@anttijk
Copy link
Contributor

anttijk commented Sep 1, 2022

Nice!

@rniwa rniwa mentioned this pull request Sep 1, 2022
Open
@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 1, 2022
@rniwa
Enable :dir by default
e9619fe 
https://bugs.webkit.org/show_bug.cgi?id=244663

Reviewed by Antti Koivisto.

Enable :dir since the implementation is complete and we pass all relevant WPT tests.

* LayoutTests/platform/win/TestExpectations:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:

Canonical link: https://commits.webkit.org/254051@main
@webkit-commit-queue
Copy link
Collaborator

Committed 254051@main (e9619fe): https://commits.webkit.org/254051@main

Reviewed commits have been landed. Closing PR #3907 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit e9619fe into WebKit:main Sep 1, 2022
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 1, 2022
@rniwa rniwa deleted the fix244663 branch September 21, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

@smfr smfr Awaiting requested review from smfr

Assignees

@rniwa rniwa

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rniwa @webkit-early-warning-system @anttijk @webkit-commit-queue