navigator.userActivation API to query user activation state #4841

marcoscaceres · 2022-09-29T23:36:27Z

`2df18f6`

navigator.userActivation API to query user activation state
https://bugs.webkit.org/show_bug.cgi?id=245240

Reviewed by Youenn Fablet and Geoffrey Garen.

Implementation of the UserActivation interface:
https://html.spec.whatwg.org/#the-useractivation-interface

Which was added to HTML via:
whatwg/html#8254

The API provides web content a view into DOMWindow::hasTransientActivation()
and DOMWindow::hasStickyActivation(). This change excludes anything
related "MessageEvent", which has not yet been agreed to by the WHATWG.

The tests have been modified to work on WebKit infrastructure without
changing the intent of the original tests. In particular:

* `domains[www1]` and so on, so those are changed to `hosts[alt][]`
* Domains are differentiated by using different ports.
* Some of the tests are missing `await`.
* Some tests would run before the body was ready.

A PR has been sent to WPT to address these issues:
web-platform-tests/wpt#36881

The tests are update to 1b73dcd.

Some test coming form WTP are non-standard. In particular, tests that
rely on `window.open()` and `.requestFullscreen()` are not spec'ed
to consume user activation. This is a known issue and will be addressed
as a followup in the specs and potentially as changes in WebKit.

* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-enter.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-escape.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-left.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-right.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/detached-iframe-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/detached-iframe.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-activation-api-iframe-cross-origin.sub.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-activation-api-iframe-cross-origin.sub.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-init.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-init.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key.html:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin.tentative.html.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/user-activation-interface-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/user-activation-interface.html: Added.
* LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.tentative-expected.txt: Removed.
* LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key-expected.txt:
* LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
* Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
* Source/WebCore/html/NavigatorUserActivation.cpp: Added.
(WebCore::NavigatorUserActivation::NavigatorUserActivation):
(WebCore::NavigatorUserActivation::userActivation):
(WebCore::NavigatorUserActivation::from):
(WebCore::NavigatorUserActivation::supplementName):
* Source/WebCore/html/NavigatorUserActivation.h: Added.
* Source/WebCore/html/URLSearchParams.h:
* Source/WebCore/html/UserActivation.cpp: Added.
(WebCore::UserActivation::create):
(WebCore::UserActivation::UserActivation):
(WebCore::UserActivation::navigator):
(WebCore::UserActivation::window const):
(WebCore::UserActivation::hasBeenActive const):
(WebCore::UserActivation::isActive const):
* Source/WebCore/html/UserActivation.h: Added.
* Source/WebCore/html/UserActivation.idl: Added.
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::hasStickyActivation const):
* Source/WebCore/page/DOMWindow.h:
* Source/WebCore/page/Navigator+UserActivation.idl: Added.

Canonical link: https://commits.webkit.org/256572@main

a63472b

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-09-29T23:36:55Z

EWS run on previous version of this PR (hash 277db8a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	~~🛠 ios~~	⏳ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	~~🛠 ios-sim~~	⏳ 🛠 mac-debug	~~🛠 gtk~~	⏳ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 api-mac	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc	~~🛠 tv~~	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~	⏳ 🧪 mac-wk2	~~🧪 jsc-armv7-tests~~
	~~🛠 watch~~	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	~~🛠 watch-sim~~	⏳ 🧪 mac-wk2-stress	~~🧪 jsc-mips-tests~~

webkit-early-warning-system · 2022-09-29T23:42:06Z

EWS run on previous version of this PR (hash 3d1b658)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	⏳ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	⏳ 🧪 api-mac	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	❌ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	⏳ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-30T01:38:23Z

EWS run on previous version of this PR (hash 443b261)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-30T04:52:25Z

EWS run on current version of this PR (hash 747db52)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
⏳ 🧪 bindings	⏳ 🛠 ios-sim	⏳ 🛠 mac-debug	🛠 gtk	🛠 wincairo
⏳ 🧪 webkitperl	⏳ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	🧪 gtk-wk2
	⏳ 🧪 api-ios	🧪 api-mac	🧪 api-gtk
⏳ 🛠 🧪 jsc	⏳ 🛠 tv	🧪 mac-wk1	⏳ 🛠 jsc-armv7
🧪 services	⏳ 🛠 tv-sim	🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	🛠 watch	⏳ 🧪 mac-AS-debug-wk2	⏳ 🛠 jsc-mips
	⏳ 🛠 watch-sim	🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-09-30T04:52:27Z

EWS run on previous version of this PR (hash 747db52)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	⏳ 🛠 wpe	⏳ 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 api-mac	⏳ 🧪 api-gtk
~~🛠 🧪 jsc~~	❌ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

Source/WebCore/bindings/js/WebCoreBuiltinNames.h

Source/WebCore/html/NavigatorUserActivation.cpp

webkit-early-warning-system · 2022-09-30T05:57:23Z

EWS run on previous version of this PR (hash 2daccbc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-03T04:29:10Z

EWS run on previous version of this PR (hash d692d02)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	~~🛠 🧪 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🛠 mac-AS-debug	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	⏳ 🧪 api-mac	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	⏳ 🧪 mac-wk2	~~🧪 jsc-armv7-tests~~
	✅ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	⏳ 🧪 mac-wk2-stress	⏳ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-03T04:31:10Z

EWS run on current version of this PR (hash e5ee638)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
🧪 style	🛠 ios	⏳ 🛠 mac	🛠 wpe	🛠 🧪 win
🧪 bindings	🛠 ios-sim	⏳ 🛠 mac-debug	🛠 gtk	🛠 wincairo
⏳ 🧪 webkitperl	🧪 ios-wk2	⏳ 🛠 mac-AS-debug	🧪 gtk-wk2
	🧪 api-ios	⏳ 🧪 api-mac	🧪 api-gtk
🛠 🧪 jsc	🛠 tv	⏳ 🧪 mac-wk1	⏳ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	⏳ 🧪 mac-wk2	⏳ 🧪 jsc-armv7-tests
	🛠 watch	⏳ 🧪 mac-AS-debug-wk2	🛠 jsc-mips
	🛠 watch-sim	⏳ 🧪 mac-wk2-stress	🧪 jsc-mips-tests

webkit-early-warning-system · 2022-10-03T04:31:11Z

EWS run on previous version of this PR (hash e5ee638)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

youennf

LGTM.
Can you add some comments in the commit message?
For instance, the link to the spec and what is being implemented.
It does not seem the whole spec is implemented (integration with MessageEvent, maybe worker support).

youennf · 2022-10-03T07:41:52Z

Source/WebCore/html/UserActivation.h

+    static Ref<UserActivation> create(Navigator&);
+    ~UserActivation();
+
+    Navigator* navigator();


Given it seems from the tests MessageEvent might be able to own a UserActivation, is there a chance it gets exposed to workers as well?
I am not exactly sure how hasBeenActive/isActive would be computed in that case.
Maybe UserActivation would use its Navigator reference only in case it is called from a Document context?

In any case, I would tend to make navigator() private so that it is only used internally.

I don't think we want to support the MessageEvent aspect (at least, not yet). It's not part of the HTML spec also and the PR this change is based on.

Sorry, I should have made that clear in the (non-existent) commit message.

youennf · 2022-10-03T07:41:59Z

Source/WebCore/html/UserActivation.h

+    bool isActive();
+
+private:
+    UserActivation(Navigator&);


Source/WebCore/html/UserActivation.h

youennf · 2022-10-03T07:43:28Z

Source/WebCore/page/DOMWindow.h

@@ -185,6 +185,7 @@ class DOMWindow final
    MonotonicTime lastActivationTimestamp() const { return m_lastActivationTimestamp; }
    void notifyActivated(MonotonicTime);
    WEBCORE_EXPORT bool hasTransientActivation() const;
+    WEBCORE_EXPORT bool hasStickyActivation() const;


I am not sure WEBCORE_EXPORT is required at the moment.

LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt

Source/WebCore/html/NavigatorUserActivation.h

webkit-early-warning-system · 2022-10-04T04:05:03Z

EWS run on previous version of this PR (hash f7da745)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	~~🧪 api-mac~~	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	❌ 🧪 mac-wk1	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-08T05:04:13Z

EWS run on previous version of this PR (hash a5e2bbc)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-08T09:16:52Z

EWS run on previous version of this PR (hash 46be888)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

youennf

It seems the WPT test changes mix WebKit specific changes and resync of WPT tests.
Can you clarify in the commit message what is what.
If there are WebKit specific changes, can you create a WPT PR?

youennf · 2022-11-08T09:16:23Z

Source/WebCore/html/NavigatorUserActivation.cpp

+    return m_userActivation;
+}
+
+NavigatorUserActivation* NavigatorUserActivation::from(Navigator& navigator)


Can it be a NavigatorUserActivation&?

Went with Ref<> instead...

youennf · 2022-11-08T09:16:52Z

Source/WebCore/html/NavigatorUserActivation.cpp

+    return NavigatorUserActivation::from(navigator)->userActivation();
+}
+
+RefPtr<UserActivation> NavigatorUserActivation::userActivation()


Can it be a Ref or a UserActivation&?

youennf · 2022-11-08T09:17:41Z

Source/WebCore/html/NavigatorUserActivation.cpp

+
+RefPtr<UserActivation> NavigatorUserActivation::userActivation(Navigator& navigator)
+{
+    return NavigatorUserActivation::from(navigator)->userActivation();


NavigatorUserActivation::from(navigator) cannot be null here probably

I would imagine not, as NavigatorUserActivation::from always assures creation.

Source/WebCore/html/URLSearchParams.h

marcoscaceres · 2022-11-09T01:53:52Z

It seems the WPT test changes mix WebKit specific changes and resync of WPT tests.
Can you clarify in the commit message what is what.

Will do. However, the PR below re-syncs everything.

If there are WebKit specific changes, can you create a WPT PR?

Sent web-platform-tests/wpt#36881

webkit-early-warning-system · 2022-11-09T05:15:40Z

EWS run on previous version of this PR (hash 9fbbfb0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
	❌ 🛠 ios-sim	❌ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-wk1
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2
	❌ 🛠 watch	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 watch-sim	❌ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-09T05:15:41Z

EWS run on previous version of this PR (hash 54fe377)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	❌ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 api-mac	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2022-11-09T06:40:54Z

EWS run on previous version of this PR (hash 8dbda63)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-10T04:17:50Z

EWS run on previous version of this PR (hash d56e52d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	✅ 🧪 api-mac	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-wk1~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

webkit-early-warning-system · 2022-11-10T08:19:15Z

EWS run on current version of this PR (hash a63472b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
✅ 🛠 🧪 merge	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

https://bugs.webkit.org/show_bug.cgi?id=245240 Reviewed by Youenn Fablet and Geoffrey Garen. Implementation of the UserActivation interface: https://html.spec.whatwg.org/#the-useractivation-interface Which was added to HTML via: whatwg/html#8254 The API provides web content a view into DOMWindow::hasTransientActivation() and DOMWindow::hasStickyActivation(). This change excludes anything related "MessageEvent", which has not yet been agreed to by the WHATWG. The tests have been modified to work on WebKit infrastructure without changing the intent of the original tests. In particular: * `domains[www1]` and so on, so those are changed to `hosts[alt][]` * Domains are differentiated by using different ports. * Some of the tests are missing `await`. * Some tests would run before the body was ready. A PR has been sent to WPT to address these issues: web-platform-tests/wpt#36881 The tests are update to 1b73dcd. Some test coming form WTP are non-standard. In particular, tests that rely on `window.open()` and `.requestFullscreen()` are not spec'ed to consume user activation. This is a known issue and will be addressed as a followup in the specs and potentially as changes in WebKit. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-enter.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-escape.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-left.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-right.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-pointerevent.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-crossorigin.sub.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/consumption-sameorigin.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/detached-iframe-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/detached-iframe.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-activation-api-iframe-cross-origin.sub.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-activation-api-iframe-cross-origin.sub.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-init.tentative-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/message-event-init.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-crossorigin.sub.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/navigation-state-reset-sameorigin.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key.html: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-crossorigin.sub.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin.tentative.html. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/propagation-sameorigin.tentative-expected.txt: Removed. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/user-activation-interface-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/user-activation-interface.html: Added. * LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/user-activation/chained-setTimeout.tentative-expected.txt: Removed. * LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/user-activation/no-activation-thru-escape-key-expected.txt: * LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt: * Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/html/NavigatorUserActivation.cpp: Added. (WebCore::NavigatorUserActivation::NavigatorUserActivation): (WebCore::NavigatorUserActivation::userActivation): (WebCore::NavigatorUserActivation::from): (WebCore::NavigatorUserActivation::supplementName): * Source/WebCore/html/NavigatorUserActivation.h: Added. * Source/WebCore/html/URLSearchParams.h: * Source/WebCore/html/UserActivation.cpp: Added. (WebCore::UserActivation::create): (WebCore::UserActivation::UserActivation): (WebCore::UserActivation::navigator): (WebCore::UserActivation::window const): (WebCore::UserActivation::hasBeenActive const): (WebCore::UserActivation::isActive const): * Source/WebCore/html/UserActivation.h: Added. * Source/WebCore/html/UserActivation.idl: Added. * Source/WebCore/page/DOMWindow.cpp: (WebCore::DOMWindow::hasStickyActivation const): * Source/WebCore/page/DOMWindow.h: * Source/WebCore/page/Navigator+UserActivation.idl: Added. Canonical link: https://commits.webkit.org/256572@main

webkit-commit-queue · 2022-11-11T17:09:48Z

Committed 256572@main (2df18f6): https://commits.webkit.org/256572@main

Reviewed commits have been landed. Closing PR #4841 and removing active labels.

marcoscaceres self-assigned this Sep 29, 2022

marcoscaceres added UI Events For bugs related to user interactions like keyboard, mouse, and touch events. WebKit Nightly Build labels Sep 29, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 29, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

hortont424 reviewed Sep 30, 2022

View reviewed changes

Source/WebCore/bindings/js/WebCoreBuiltinNames.h Outdated Show resolved Hide resolved

Source/WebCore/html/NavigatorUserActivation.cpp Outdated Show resolved Hide resolved

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 30, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 3, 2022

marcoscaceres marked this pull request as ready for review October 3, 2022 07:21

marcoscaceres requested review from cdumez and rniwa as code owners October 3, 2022 07:21

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 3, 2022

youennf reviewed Oct 3, 2022

View reviewed changes

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Oct 4, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 4, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022

youennf approved these changes Nov 8, 2022

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 8, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022

marcoscaceres mentioned this pull request Nov 9, 2022

User activation: refactor to support WebKit infrastructure web-platform-tests/wpt#36881

Merged

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 9, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022

marcoscaceres removed the merging-blocked Applied to prevent a change from being merged label Nov 10, 2022

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 11, 2022

eric-carlson added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 11, 2022

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 11, 2022

webkit-early-warning-system merged commit 2df18f6 into WebKit:main Nov 11, 2022

marcoscaceres deleted the eng/navigator-userActivation-API-to-query-user-activation-state branch November 15, 2022 00:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

navigator.userActivation API to query user activation state #4841

navigator.userActivation API to query user activation state #4841

marcoscaceres commented Sep 29, 2022 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Sep 29, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 29, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 3, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 3, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 3, 2022 •

edited

Loading

youennf left a comment

youennf Oct 3, 2022

marcoscaceres Oct 4, 2022

youennf Oct 3, 2022

youennf Oct 3, 2022

webkit-early-warning-system commented Oct 4, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2022 •

edited

Loading

youennf left a comment

youennf Nov 8, 2022

marcoscaceres Nov 9, 2022

youennf Nov 8, 2022

youennf Nov 8, 2022

marcoscaceres Nov 9, 2022

marcoscaceres commented Nov 9, 2022

webkit-early-warning-system commented Nov 9, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 9, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 9, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 10, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 10, 2022 •

edited

Loading

webkit-commit-queue commented Nov 11, 2022

navigator.userActivation API to query user activation state #4841

navigator.userActivation API to query user activation state #4841

Conversation

marcoscaceres commented Sep 29, 2022 • edited by webkit-early-warning-system Loading

webkit-early-warning-system commented Sep 29, 2022 • edited Loading

webkit-early-warning-system commented Sep 29, 2022 • edited Loading

webkit-early-warning-system commented Sep 30, 2022 • edited Loading

webkit-early-warning-system commented Sep 30, 2022 • edited Loading

webkit-early-warning-system commented Sep 30, 2022 • edited Loading

webkit-early-warning-system commented Sep 30, 2022 • edited Loading

webkit-early-warning-system commented Oct 3, 2022 • edited Loading

webkit-early-warning-system commented Oct 3, 2022 • edited Loading

webkit-early-warning-system commented Oct 3, 2022 • edited Loading

youennf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Oct 4, 2022 • edited Loading

webkit-early-warning-system commented Nov 8, 2022 • edited Loading

webkit-early-warning-system commented Nov 8, 2022 • edited Loading

youennf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcoscaceres commented Nov 9, 2022

webkit-early-warning-system commented Nov 9, 2022 • edited Loading

webkit-early-warning-system commented Nov 9, 2022 • edited Loading

webkit-early-warning-system commented Nov 9, 2022 • edited Loading

webkit-early-warning-system commented Nov 10, 2022 • edited Loading

webkit-early-warning-system commented Nov 10, 2022 • edited Loading

webkit-commit-queue commented Nov 11, 2022

marcoscaceres commented Sep 29, 2022 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Sep 29, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 29, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Sep 30, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 3, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 3, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 3, 2022 •

edited

Loading

webkit-early-warning-system commented Oct 4, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 8, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 9, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 9, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 9, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 10, 2022 •

edited

Loading

webkit-early-warning-system commented Nov 10, 2022 •

edited

Loading