Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION (256665@main): [ Ventura ] fast/images/avif-as-image.html is a consistent image failure #7287

Conversation

shallawa
Copy link
Contributor

@shallawa shallawa commented Dec 7, 2022

c7d2aef

REGRESSION (256665@main): [ Ventura ] fast/images/avif-as-image.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=248544
rdar://102823196

Reviewed by Simon Fraser.

libavif does not render fast/images/resources/green-313x313.avif and
fast/images/resources/green-400x400.avif correctly.

See AOMediaCodec/av1-avif#195

We need to fix the expectation file fast/images/avif-as-image-expected.html
with the correct rendering; i.e. the image should be lime not green. This will
require marking this test [ ImageOnlyFailure ] for non Apple ports and macOS
down-level ports.

* LayoutTests/TestExpectations:
* LayoutTests/fast/images/avif-as-image-expected.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-ventura/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/257738@main

4a151bd

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 merge 💥 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@shallawa shallawa self-assigned this Dec 7, 2022
@shallawa shallawa added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Dec 7, 2022
@shallawa shallawa requested a review from smfr December 7, 2022 22:34
@shallawa shallawa force-pushed the eng/REGRESSION-256665main--Ventura--fastimagesavif-as-image-html-is-a-consistent-image-failure branch from 92e3620 to 4a151bd Compare December 8, 2022 18:40
@shallawa shallawa added the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-256665main--Ventura--fastimagesavif-as-image-html-is-a-consistent-image-failure branch from 4a151bd to 176ac0e Compare December 12, 2022 18:40
…is a consistent image failure

https://bugs.webkit.org/show_bug.cgi?id=248544
rdar://102823196

Reviewed by Simon Fraser.

libavif does not render fast/images/resources/green-313x313.avif and
fast/images/resources/green-400x400.avif correctly.

See AOMediaCodec/av1-avif#195.

We need to fix the expectation file fast/images/avif-as-image-expected.html
with the correct rendering; i.e. the image should be lime not green. This will
require marking this test [ ImageOnlyFailure ] for non Apple ports and macOS
down-level ports.

* LayoutTests/TestExpectations:
* LayoutTests/fast/images/avif-as-image-expected.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac-ventura/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/257738@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/REGRESSION-256665main--Ventura--fastimagesavif-as-image-html-is-a-consistent-image-failure branch from 176ac0e to c7d2aef Compare December 12, 2022 18:43
@webkit-early-warning-system webkit-early-warning-system merged commit c7d2aef into WebKit:main Dec 12, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 257738@main (c7d2aef): https://commits.webkit.org/257738@main

Reviewed commits have been landed. Closing PR #7287 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants