-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable libcurl as the network backend #7
Conversation
There is a switch to enable libsoup (ENABLE_SOUP) in the Features.Nix.config.
The WebKitNix.pc file now reflects correctly the required network library.
I have the dream of a having Nix free of glib in the future, do you think this is reasonable for libCurl backend? I'm not saying to remove the GIO code now, I'm just asking if this would be possible without too much work in the future. |
Definitely, I believe this an important motivation behind moving to libCurl. If I recall correctly it does not have any dependencies beside libc. |
Nice, my advice is: Don't worry with it (glib) right now, one step at a time :-) |
At first I wanted to use simple socket calls (for the stream handler and the inspector server), but this was way faster :) . Only one thing is bit tricky and that is the handling the socket data in an async fashion (what the GIO does easly in this case) |
So... can we go forward with this? |
Yay! Nice job guys, I'll use that as the baseline for my pull request adding WebSockets/InspectorServer support |
So this patch set will allow WebKitNix to be build with libcurl thus replacing libsoup as the network backend.
By default it will still be built with libsoup but there is a
ENABLE_SOUP
in theFeaturesNix.config
file which if set to0
will disable the libsoup and thus WebKit will be built with the libcurl.