Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable libcurl as the network backend #7

Closed
wants to merge 3 commits into from

Conversation

elecro
Copy link

@elecro elecro commented May 9, 2013

So this patch set will allow WebKitNix to be build with libcurl thus replacing libsoup as the network backend.

By default it will still be built with libsoup but there is a ENABLE_SOUP in the FeaturesNix.config file which if set to 0 will disable the libsoup and thus WebKit will be built with the libcurl.

elecro added 3 commits May 9, 2013 18:42
There is a switch to enable libsoup (ENABLE_SOUP) in the Features.Nix.config.
The WebKitNix.pc file now reflects correctly the required network library.
@hugopl
Copy link
Member

hugopl commented May 9, 2013

I have the dream of a having Nix free of glib in the future, do you think this is reasonable for libCurl backend?

I'm not saying to remove the GIO code now, I'm just asking if this would be possible without too much work in the future.

@balazs
Copy link

balazs commented May 9, 2013

Definitely, I believe this an important motivation behind moving to libCurl. If I recall correctly it does not have any dependencies beside libc.

@hugopl
Copy link
Member

hugopl commented May 9, 2013

Nice, my advice is: Don't worry with it (glib) right now, one step at a time :-)

@elecro
Copy link
Author

elecro commented May 10, 2013

At first I wanted to use simple socket calls (for the stream handler and the inspector server), but this was way faster :) . Only one thing is bit tricky and that is the handling the socket data in an async fashion (what the GIO does easly in this case)

@elecro
Copy link
Author

elecro commented May 13, 2013

So... can we go forward with this?

@hugopl
Copy link
Member

hugopl commented May 22, 2013

Merged on commits: 6c6538e and b793fd3

@hugopl hugopl closed this May 22, 2013
@kromain
Copy link

kromain commented May 22, 2013

Yay! Nice job guys, I'll use that as the baseline for my pull request adding WebSockets/InspectorServer support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants