Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependencies, move dev dependencies #128

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Nov 3, 2023

Clean up dependencies as a preparation for a future npm publish. (#127)

  • Moved testing and build dependencies from "dependencies" to "devDependencies" to avoid having development dependencies shipped with published package. Also allows us to run npm audit --omit=dev to run audit on only runtime dependencies if we want.

  • Remove dependencies not used from root package.json

  • Remove typescript and eslint dependencies from the examples/scripts and examples/integration-scripts packages. They will just use the typescript and ts-node packages from the root package using nodes module resolution. I think this is better to avoid having multiple versions of typescript installed here.

  • Upgrade typescript to 5.1. Latest is 5.1. The scripts used tsconfig settings that were not intruduced until v5, but tsdx or puppeteer had dependencies requiring <= 5.1. Note reverted this change because tsdx was not compatible with typescript v5 dues to outdated testing libraries. See also Consider moving away from tsdx #130

@lenkan lenkan marked this pull request as draft November 3, 2023 15:25
@lenkan lenkan marked this pull request as ready for review November 3, 2023 15:49
@lenkan lenkan force-pushed the remove-unused-dependencies branch from 56394e8 to ddefaaf Compare November 8, 2023 13:12
@lenkan lenkan force-pushed the remove-unused-dependencies branch from ddefaaf to 8cd2ad4 Compare November 8, 2023 13:13
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #128 (8cd2ad4) into development (9f020f2) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #128   +/-   ##
============================================
  Coverage        80.94%   80.94%           
============================================
  Files               42       42           
  Lines             4173     4173           
  Branches          1028     1028           
============================================
  Hits              3378     3378           
  Misses             763      763           
  Partials            32       32           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@m00sey m00sey requested a review from rodolfomiranda November 9, 2023 15:20
@rodolfomiranda
Copy link
Collaborator

great clean up. Thanks!

Copy link
Collaborator

@rodolfomiranda rodolfomiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodolfomiranda rodolfomiranda merged commit 031fde6 into WebOfTrust:development Nov 9, 2023
4 checks passed
@lenkan lenkan deleted the remove-unused-dependencies branch December 4, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants