Skip to content

Commit

Permalink
[GStreamer] Workaround for duration not properly updated for MP3
Browse files Browse the repository at this point in the history
Add FIXME comment and fix quotes
  • Loading branch information
albertd authored Feb 1, 2017
1 parent 7ced498 commit 16e0f0b
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,8 @@ void MediaPlayerPrivateGStreamer::handleMessage(GstMessage* message)
break;
case GST_MESSAGE_DURATION_CHANGED:
// Duration in MSE is managed by MediaSource, SourceBuffer and AppendPipeline.
if (!isMediaSource() && (messageSourceIsPlaybin || g_strstr_len(GST_MESSAGE_SRC_NAME(message), 14, "mpegaudioparse”)))
// FIXME: Gstreamer upstream issue getting the MP3 duration, workaround applied by getting the duration from mpegaudioparse.
if (!isMediaSource() && (messageSourceIsPlaybin || g_strstr_len(GST_MESSAGE_SRC_NAME(message), 14, "mpegaudioparse")))
durationChanged();
break;
case GST_MESSAGE_REQUEST_STATE:
Expand Down

0 comments on commit 16e0f0b

Please sign in to comment.