-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WTFCrash in JavaScriptCore during Youtube video playback #405
Comments
Are you using the sampling profiler when this happens (from the web inspector)? |
Steps to reproduce:
|
I think this crash is same/similar to #327 |
We are still observing this crash with the latest JavaScriptCore fixes. |
For the JavaScriptCore crash we are observing, based on the stacktrace it looks like from one thread we are releasing the resource and form another thread we are trying to access the same resource which is causing major of the crashes I think we should have some kind of locks while releasing and accessing/using the resource to avoid these crashes. In our case since we set the memory limit to 150MB we do see MemoryPressureHandler calling GC more frequently when memory usage reaches >150MB |
Update on my attempts to reproduce: I had a bunch of crashes, but that looked unrelated and due to the graphics drivers of my device. I updated said drivers and launched some long time youtube playback again. That was a few hours ago, I will see if the crash reproduces over the week end. |
@aazamansari Is that a crash that you are still able to reproduce? We have a patch for an issue that might be the same as yours that could be interesting to try. |
Hi @guijemont , |
@nambirajang I've backported a patch that might fix it. Please test with itand let me know if the issue still reproduces. Also please note that this is not the permanent fix that will land upstream, and it could potentially have some side effects, so it would require extensive testing before using it in production. |
Thanks @guijemont . I will apply this patch and update you the result. |
Hi @guijemont , Thanks. |
I believe this has a high chance of being fixed by 80c2847. If you are still able to reproduce the issue, can you check whether this fixes it? (I expect the patch should be trivial to apply on wpe-20170728 ) |
Patch has been backported to the wpe-20170728 branch, let me know if this looks like it fixes the issue for you. |
Inactive ticket for long time! Closing the ticket; if you think it is still relevant and/or valid for the latest version/s. Please do not hesitate to re-open! |
Hi @guijemont,
We are observing WTFCrash in JSC during youtube video playback in 5c0c3fd wpe stable version.
Issue is seen in ARM & Mips platforms and we used O2 optimization flag in wpe compilation.
WTFCrash-1.txt
WTFCrash-2.txt
WTFCrash-3.txt
The text was updated successfully, but these errors were encountered: