Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTFCrash in JavaScriptCore during Youtube video playback #405

Closed
nrajan002c opened this issue Nov 13, 2017 · 14 comments
Closed

WTFCrash in JavaScriptCore during Youtube video playback #405

nrajan002c opened this issue Nov 13, 2017 · 14 comments
Assignees

Comments

@nrajan002c
Copy link

Hi @guijemont,
We are observing WTFCrash in JSC during youtube video playback in 5c0c3fd wpe stable version.
Issue is seen in ARM & Mips platforms and we used O2 optimization flag in wpe compilation.
WTFCrash-1.txt
WTFCrash-2.txt
WTFCrash-3.txt

@guijemont guijemont self-assigned this Nov 13, 2017
@guijemont
Copy link

Are you using the sampling profiler when this happens (from the web inspector)?

@nrajan002c
Copy link
Author

Steps to reproduce:

  1. Start Youtube video playback.
  2. Leave it for long run.

@aazamansari
Copy link

aazamansari commented May 1, 2018

I think this crash is same/similar to #327

@aazamansari
Copy link

We are still observing this crash with the latest JavaScriptCore fixes.

@aazamansari
Copy link

For the JavaScriptCore crash we are observing, based on the stacktrace it looks like from one thread we are releasing the resource and form another thread we are trying to access the same resource which is causing major of the crashes

I think we should have some kind of locks while releasing and accessing/using the resource to avoid these crashes.

In our case since we set the memory limit to 150MB we do see MemoryPressureHandler calling GC more frequently when memory usage reaches >150MB

@guijemont
Copy link

Update on my attempts to reproduce: I had a bunch of crashes, but that looked unrelated and due to the graphics drivers of my device. I updated said drivers and launched some long time youtube playback again. That was a few hours ago, I will see if the crash reproduces over the week end.
Alternatively, if someone who can reproduce easily can provide a core file + build files, that would be welcome as well, as it's hard to conclude anything from the backtraces alone.

@guijemont
Copy link

@aazamansari Is that a crash that you are still able to reproduce? We have a patch for an issue that might be the same as yours that could be interesting to try.

@nrajan002c
Copy link
Author

Hi @guijemont ,
This issue is still reproducible in our STB. Could you please share the patch.
We can try it out.

@guijemont
Copy link

@nambirajang I've backported a patch that might fix it. Please test with itand let me know if the issue still reproduces.

Also please note that this is not the permanent fix that will land upstream, and it could potentially have some side effects, so it would require extensive testing before using it in production.
For more details see the upstream issue

@nrajan002c
Copy link
Author

Thanks @guijemont . I will apply this patch and update you the result.

@nrajan002c
Copy link
Author

Hi @guijemont ,
JSC crash is still observed with the fix.
We are using "c0bb44a4053c261212b865e74b553816d88a9d37" revision in wpe-20170728 branch.
I have attached the minidump stack trace. can you please check it.
crash.docx

Thanks.

@guijemont
Copy link

I believe this has a high chance of being fixed by 80c2847. If you are still able to reproduce the issue, can you check whether this fixes it? (I expect the patch should be trivial to apply on wpe-20170728 )

@guijemont
Copy link

Patch has been backported to the wpe-20170728 branch, let me know if this looks like it fixes the issue for you.

@modeveci
Copy link

Inactive ticket for long time!

Closing the ticket; if you think it is still relevant and/or valid for the latest version/s. Please do not hesitate to re-open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants