Comcast modifications #15
Conversation
| @@ -1725,12 +1740,12 @@ void AppendPipeline::connectToAppSinkFromAnyThread(GstPad* demuxerSrcPad) | |||
| connectToAppSink(demuxerSrcPad); | |||
| } else { | |||
| // Call connectToAppSink() in the main thread and wait. | |||
| PadInfo* info = new PadInfo(demuxerSrcPad, this); | |||
| info->lock(); | |||
| GMutexLocker lock(&m_padAddRemoveMutex); | |||
There was a problem hiding this comment.
This won't compile, needs to be WTF::GMutexLocker lock(....)
There was a problem hiding this comment.
include WTF's GMutexLocker.h header, then WTF::GMutexLocker<GMutex> lock(m_....)
|
I tested this and I see a bunch of ERROR webkitmediaplayer MediaPlayerPrivateGStreamerMSE.cpp:1416:setAppendStage: Invalid append stage transition Ongoing --> Ongoing now. The state machine needs fixing. |
|
Is the setAppendStage error fixed in this new version? |
|
Yes, the 'Ongoing --> Ongoing' is fixed. Previous pull request missed some changes, this one should be ok. |
| @@ -213,6 +213,9 @@ MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer() | |||
| ASSERT(bus); | |||
| gst_bus_set_sync_handler(bus.get(), nullptr, nullptr, nullptr); | |||
| g_signal_handlers_disconnect_matched(m_pipeline.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this); | |||
| // BRCM specific, flush to unlock aud/vid filters | |||
There was a problem hiding this comment.
Could you please suggest the define to hide this under.
There was a problem hiding this comment.
WPE_BACKEND is not available in WebCore and WPE_BACKEND_BCM_NEXUS is defined only for WPE module, changing that seems to be out of current task scope.
There was a problem hiding this comment.
I can remove this change from pull request so we can proceed with other changes. This patch is needed when brcm decoders limit_buffering is enabled, so you should be good without it.
There was a problem hiding this comment.
Ok let's remove that patch for now then.
The fix I'm suggesting is to define WTF_PLATFORM_BRCM to 1 during the build, so that you can use #if PLATFORM(BRCM) in the code.
[MSE] leak fixes and improvements
I haven't tried this with WPE, so it may be specific to qtwebkit we use. Please review.