[UpdateAtlas] Do not useGeneralAreaAllocator to allocate space. #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not using the UpdateAtlas as a buffer to paint several areas, but just to paint a single one, so it doesn't make sense to use an AreaAllocator to allocate an area inside the current atlas to paint to. Also, with the current implementation, the GeneralAreaAlocator would give errors when allocating areas smaller than half of the minimum size.
zdobersek
added a commit
that referenced
this pull request
Mar 8, 2016
[UpdateAtlas] Do not useGeneralAreaAllocator to allocate space.
Closed
This was referenced Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not using the UpdateAtlas as a buffer to paint several areas, but just
to paint a single one, so it doesn't make sense to use an AreaAllocator
to allocate an area inside the current atlas to paint to.
Also, with the current implementation, the GeneralAreaAlocator would give
errors when allocating areas smaller than half of the minimum size.