CMakeLists: Find wayland and wayland-egl #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westeros backend depends on it. Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
This will give build error on our box as in our case westeros is not dependent on waylandegl. |
|
@aazamansari you should fix that in platform Cmake files. |
|
LGTM |
zdobersek
pushed a commit
that referenced
this pull request
May 22, 2017
https://bugs.webkit.org/show_bug.cgi?id=171942 <rdar://problem/32054234> Reviewed by Tim Horton. Source/WebCore: There are some Unicode characters which don't have any font on the system which can render them. These characters should be drawn as the .notdef "tofu." This is for security and usability, as well as what Firefox and Chrome do. However, we still shouldn't draw characters with the Default_Ignorable_Code_Point property, because this is what CoreText does. This behavior is also what the Unicode spec recommends: In UTR #36 Unicode Security Considerations: http://www.unicode.org/reports/tr36/#Recommendations_General "If there is no available glyph for a character, never show a simple "?" or omit the character." Also relevant is the Unicode Standard section 5.3 Unknown and MIssing Characters, starting at page marked 203 in the following: http://www.unicode.org/versions/Unicode9.0.0/ch05.pdf Tests: fast/text/default-ignorable.html fast/text/unknown-char-notdef.html * platform/graphics/WidthIterator.cpp: (WebCore::characterMustDrawSomething): LayoutTests: * fast/text/default-ignorable-expected.html: Added. * fast/text/default-ignorable.html: Added. * fast/text/unknown-char-notdef-expected-mismatch.html: Added. * fast/text/unknown-char-notdef.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@216874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Closed
This was referenced Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Westeros backend depends on it.
Signed-off-by: Khem Raj raj.khem@gmail.com