Changes to enable progress event when mediadiskcache is set to FALSE. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (m_cachedPosition) | ||
| loaded = m_cachedPosition; | ||
| else | ||
| loaded = m_mediaDuration; |
There was a problem hiding this comment.
Shouldn't the value of m_mediaDuration be checked before using it?
|
I'm not sure I like the logic of this patch... Also in theory it's possible that loaded is set again in the code following down the patch and there's no log statement notifying about it. |
…– Added check & Log notification suggested by Philippe.
dwrobel
pushed a commit
to dwrobel/WPEWebKit
that referenced
this pull request
Jan 26, 2022
WebPlatformForEmbedded#58) It is matter of race result if seek completion is already detected. Some applications do not recover from waiting event without additional seeked or palying, but these do not follow on playback rate change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.