Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tests for new GuestIssuer functionality introduced in PR #74 #79

Closed
cmlccie opened this issue Apr 2, 2019 · 2 comments · Fixed by #131
Closed

Add a tests for new GuestIssuer functionality introduced in PR #74 #79

cmlccie opened this issue Apr 2, 2019 · 2 comments · Fixed by #131
Assignees

Comments

@cmlccie
Copy link
Collaborator

cmlccie commented Apr 2, 2019

@sQu4rks awesome job with the Guest Issuer PR. Thank you for submitting it!

I have merged it in, and I will push a new release with the added functionality shortly. However, we need to create some test and docs for the new functionality to ensure its reliability and to let other developers know how to use it. Can you take a run at creating the tests and docs? I'm glad to edit and review.

@sQu4rks
Copy link
Contributor

sQu4rks commented Apr 2, 2019

Thanks for merging. I'll go ahead and create the docs and tests.

@cmlccie
Copy link
Collaborator Author

cmlccie commented Apr 4, 2019

Thank you @sQu4rks !

@cmlccie cmlccie added this to the v1.x milestone Jul 7, 2020
@cmlccie cmlccie linked a pull request Jul 11, 2020 that will close this issue
@cmlccie cmlccie closed this as completed Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants