Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#127 Update the existing Webex Teams API wrappers and data models #128

Merged
merged 11 commits into from
Jul 11, 2020

Conversation

cmlccie
Copy link
Collaborator

@cmlccie cmlccie commented Jul 10, 2020

Updates the existing Webex Teams API wrappers and data models and ensure they are up-to-date with all posted parameters, attributes, and sub-endpoints published on developer.webex.com.

cmlccie added 11 commits July 10, 2020 15:13
Rename the paramater ID parameter in the get() method from `attachmentId` to `id` to be consistent with the documentation.
- Align the parameter names with those used in the documentation.
- Update the docstrings.
- The paramaters are mandatory (may not be `None`).
- Use the library restsession to submit the request. The supplied headers will me merged-in with the session's default headers; the Authentication header will replace the default Authentication header.
- Add the parentId parameter to the messages.list() method.
- Add the messages.list_direct() API endpoint.
- Update the message data model attributes.
Docstring updates.
- Update default value for `max=` in the teams.list() method.
- Make `name` a required parameter for the teams.update() method.
Update the default value for the `max=` parameter of the team_memberships.list() method.
Add the default value for the `max=` parameter of the webhooks.list() method.
- Test new messages.list_direct() method
- Test replying to messages (threading with parentId)
@cmlccie cmlccie modified the milestone: v1.x Jul 10, 2020
@cmlccie cmlccie linked an issue Jul 10, 2020 that may be closed by this pull request
15 tasks
@cmlccie cmlccie merged commit 442751e into v1.x Jul 11, 2020
@cmlccie cmlccie deleted the feature-127 branch July 11, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the existing Webex Teams API wrappers and data models
1 participant