Add Room Meeting Info API endpoint - Proposed Alternate Implementation #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set default value for `max=` parameter on the rooms.list() method. - Make `title` a required parameter for the rooms.update() method.
- Update the Rooms API with the GET `/v1/rooms/{roomId}/meetingInfo` endpoint.
- Add a RoomMeetingInfo data model
- Update the docs and tests
|
Let's use this implementation. I'll merge and delete the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sQu4rks, this is a proposed alternate implementation to PR #129 to resolve issue #100
In this version of the codebase, I prefer to keep all of the endpoints associated with an API (like the Rooms API) in the same module and hierarchically organized under the same API group under the
WebexTeamsAPItop-level connection object.Use of this endpoint under this proposal looks like this: