Migrate to Adaptive Card 1.3 Version #243
Conversation
Remove Adaptive Card Version 1.1 codes as some code refactoring is done to make way for Adaptive Card version 1.3
Code changes commit for webexpythonsdk's Adaptive Card 1.1 to 1.3 version upgrade
|
set_if_not_none() function from utils.py has been removed as I did not find any usage in the entire SDK! |
There was a problem hiding this comment.
The code was formatted well and passed the linter test. but when I went to test I ran into a Syntax Error.
The output indicated that the test run failed due to a SyntaxError in the file WebexPythonSDK/src/webexpythonsdk/models/cards/utils.py at line 58. The specific error message is SyntaxError: '(' was never closed, which means there is an unmatched opening parenthesis ( in the code.
To fix this, you need to locate the unmatched parenthesis in utils.py and ensure that every opening parenthesis has a corresponding closing parenthesis ).
|
It is surprising. I tried the same and simulated an error to reach that particular piece of code, but it worked correctly. Can you please share the adaptive card code that you've used that led to this error? |
|
Now I am getting a SyntaxError: f-string: expecting '}'. This is for src/webexpythonsdk/models/cards/utils.py Line 61. I think it has to do with the quotation mark placement. |
|
Code commit for #242 |
Code changes commit for webexpythonsdk's Adaptive Card 1.1 to 1.3 version upgrade. Changes involve code files restructuring inline with Adaptive Card's official documentation (https://adaptivecards.io/explorer/).