Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Client::getFolderByPath() #12

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Adds Client::getFolderByPath() #12

merged 2 commits into from
Oct 2, 2020

Conversation

Max13
Copy link
Contributor

@Max13 Max13 commented Oct 2, 2020

For when an accounts has multiple time the same folder name under different parent folder.

@Max13
Copy link
Contributor Author

Max13 commented Oct 2, 2020

IMHO, Client::getFolder() should have been "by path" and not "by name" from the beginning (it's more intuitive).

So if cce49a4 is accepted, then Client::getFolderByName() should exist to prevent ambiguity, without breaking compatibility

@Webklex Webklex merged commit 6dffce0 into Webklex:master Oct 2, 2020
@Webklex
Copy link
Owner

Webklex commented Oct 2, 2020

Hi @Max13 ,
thanks a lot 👍

@Max13 Max13 deleted the folder-path branch October 2, 2020 23:53
@ricuss ricuss mentioned this pull request Aug 12, 2022
Closed
@moikzz213 moikzz213 mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Max13 @Webklex