Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma in rendered lists is not localized #13896

Open
nijel opened this issue Feb 17, 2025 · 4 comments
Open

Comma in rendered lists is not localized #13896

nijel opened this issue Feb 17, 2025 · 4 comments
Assignees
Labels
Area: UX Issues related to user experience. enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. External knowledge welcome.

Comments

@nijel
Copy link
Member

nijel commented Feb 17, 2025

Describe the problem

When several values are rendered and joined with ,, it is not localized. Since 0b54da6 there is a solution for format_html_join, but there are still dozen of places where ", ".join(...) is used.

Describe the solution you would like

Use format_html_join_comma whenever the content is shown in the UI.

Describe alternatives you have considered

No response

Screenshots

No response

Additional context

No response

@nijel nijel added enhancement Adding or requesting a new feature. Area: UX Issues related to user experience. labels Feb 17, 2025
@nijel nijel added this to the 5.10.1 milestone Feb 17, 2025
@nijel nijel self-assigned this Feb 17, 2025
nijel added a commit to nijel/weblate that referenced this issue Feb 17, 2025
Include links to problematic components to make it easier to address.

Issue WeblateOrg#13896
nijel added a commit that referenced this issue Feb 17, 2025
Include links to problematic components to make it easier to address.

Issue #13896
nijel added a commit to nijel/weblate that referenced this issue Feb 20, 2025
nijel added a commit to nijel/weblate that referenced this issue Feb 20, 2025
@nijel nijel removed this from the 5.10.1 milestone Feb 20, 2025
@nijel nijel added hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. External knowledge welcome. good first issue Opportunity for newcoming contributors. labels Feb 20, 2025
@nijel
Copy link
Member Author

nijel commented Feb 20, 2025

Several issues were addressed, but there are more in the code base. Following pull requests can be examples how to address this:

Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

nijel added a commit that referenced this issue Feb 20, 2025
nijel added a commit that referenced this issue Feb 20, 2025
@Jin-Shikai
Copy link

Hi, I'm new to open source projects. May I give it a try? I'd appreciate if you could tell me where similar problems might occur.

@nijel
Copy link
Member Author

nijel commented Feb 25, 2025

Just search for ", ".join(. When that is used in something shown to the user in UI, it is a good candidate to replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UX Issues related to user experience. enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. External knowledge welcome.
Projects
None yet
Development

No branches or pull requests

2 participants