Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate commit code #3708

Closed
nijel opened this issue Apr 9, 2020 · 2 comments · Fixed by #4143
Closed

Consolidate commit code #3708

nijel opened this issue Apr 9, 2020 · 2 comments · Fixed by #4143
Assignees
@nijel
Labels
enhancement Adding or requesting a new feature.
Milestone
4.2

Comments

@nijel
Copy link
Member

nijel commented Apr 9, 2020 •
edited
Loading

Currently, there is commit code at the translation level and on component level it is handled manually. This has following implications:
@nijel nijel added the enhancement Adding or requesting a new feature. label Apr 9, 2020
@nijel nijel mentioned this issue Apr 9, 2020
Closed
@nijel nijel added this to the 4.2 milestone Jun 12, 2020
@nijel nijel self-assigned this Jul 8, 2020
nijel added a commit that referenced this issue Jul 8, 2020
@nijel
Component: Remove translation from post_commit signal
a55687e 
It is not used anywhere and removing it will allow to simplify the
commit code.

Issue #3708
nijel added a commit that referenced this issue Jul 8, 2020
@nijel
VCS: Add type hints for commit and remove
2c2faf3 
This will make it easier to check hints in above code, see #3708.

Issue #3703
@nijel nijel mentioned this issue Jul 8, 2020
Merged
4 tasks
@nijel nijel closed this as completed in ad93135 Jul 8, 2020
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Component: Consolidate commit code
1 participant
@nijel