Use WEBLATE_GITLAB_USERNAME environment variable #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used in the code.
Codecov Report
@@ Coverage Diff @@
## master #3318 +/- ##
=========================================
Coverage ? 81.92%
=========================================
Files ? 593
Lines ? 42988
Branches ? 5630
=========================================
Hits ? 35220
Misses ? 6821
Partials ? 947 |
nijel
reviewed
Dec 18, 2019
| @@ -203,6 +203,10 @@ | |||
| # Please see the documentation for more details. | |||
| GITHUB_USERNAME = os.environ.get("WEBLATE_GITHUB_USERNAME", None) | |||
|
|
|||
| # GitHub username for sending pull requests. | |||
There was a problem hiding this comment.
Can you please adjust the comment as well?
Suggested change
| # GitHub username for sending pull requests. | |
| # GitLab username for sending pull requests. |
|
Good point, the other part which is missing is lab being installed in the Docker image, see WeblateOrg/docker#467 |
This was referenced Dec 19, 2019
nijel
added a commit
that referenced
this pull request
Dec 20, 2019
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WEBLATE_GITLAB_USERNAME environment variable is specified in the documentation. But it is never assigned.