Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Replace bleach by nh3 #8664

Merged
merged 1 commit into from
Jan 25, 2023
Merged

deps: Replace bleach by nh3 #8664

merged 1 commit into from
Jan 25, 2023

Conversation

nijel
Copy link
Member

@nijel nijel commented Jan 24, 2023

Proposed changes

Bleach is getting deprecated and nh3 is way faster.

This is not yet ready, needs messense/nh3#8

Bleach depreciation notice: mozilla/bleach#698

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel marked this pull request as ready for review January 24, 2023 13:02
@nijel nijel requested a review from orangesunny as a code owner January 24, 2023 13:02
Bleach is getting deprecated and nh3 is way faster.
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #8664 (f612676) into main (ab9fd58) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8664      +/-   ##
==========================================
- Coverage   90.85%   90.84%   -0.01%     
==========================================
  Files         700      700              
  Lines       52174    52174              
  Branches     7935     7935              
==========================================
- Hits        47402    47399       -3     
- Misses       3332     3334       +2     
- Partials     1440     1441       +1     
Impacted Files Coverage Δ
weblate/trans/tests/test_autofix.py 100.00% <ø> (ø)
weblate/utils/requirements.py 71.95% <ø> (ø)
weblate/checks/markup.py 96.51% <100.00%> (ø)
weblate/trans/autofixes/html.py 100.00% <100.00%> (ø)
weblate/utils/html.py 100.00% <100.00%> (ø)
weblate/utils/tests/test_html.py 100.00% <100.00%> (ø)
weblate/utils/requests.py 86.11% <0.00%> (-8.34%) ⬇️

@nijel nijel merged commit 299c394 into WeblateOrg:main Jan 25, 2023
@nijel nijel deleted the nh3 branch January 25, 2023 07:34
@nijel nijel self-assigned this Jan 25, 2023
@nijel nijel added this to the 4.16 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants