Fix whereIn subquery for Laravel 5.8+ #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way Laravel handles subqueries in the
whereIn()
method has changed in Laravel 5.8. (before, after). When using this library, any query bindings in the subquery within awhereIn
clause were discarded, resulting in SQL errors.For example:
Before, when a query with a
whereIn
clause with a subquery was performed, the$where['type']
would be set toInSub
orNotInSub
depending on the operator, in which case our customwhereIn
method would basically do nothing and return early.laravel-mutate/src/Database/EloquentBuilder.php
Lines 96 to 100 in b96b860
Now, with the changes in Laravel 5.8+, the check we were performing no longer applies. The
$where['type']
is always eitherIn
orNotIn
. Instead of checking the value of$where['type']
, we can just check to see if it's "queryable" using the same logic that theIlluminate\Database\Query\Builder
class uses, and return early like before.