[Laravel 6] Make newPivotQuery() method public to match parent. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suadhuskic
approved these changes
Oct 28, 2020
suadhuskic
reviewed
Oct 28, 2020
| @@ -119,7 +119,7 @@ protected function baseAttachRecord($id, $timed) | |||
| * | |||
| * @return \Illuminate\Database\Query\Builder | |||
| */ | |||
| protected function newPivotQuery() | |||
| public function newPivotQuery() | |||
There was a problem hiding this comment.
apps using 5.* would break right?
There was a problem hiding this comment.
Correct. I've updated the Laravel version required by this package to be ^6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method signature of
newPivotQuery()was changed in Laravel 6. laravel/framework#31677This fixes the failing test suite here