Skip to content

Commit

Permalink
Merge pull request #1 from WellSheet/ca/master/skip-locked
Browse files Browse the repository at this point in the history
Add `SKIP LOCKED` clause to DJ Pickup Query
  • Loading branch information
coreyja authored May 3, 2021
2 parents d65b0f9 + ab22aa4 commit 5206912
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/delayed/backend/active_record.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def self.reserve_with_scope_using_optimized_postgres(ready_scope, worker, now)
# SQL for Postgres if we use a .limit() filter, but it would not
# use 'FOR UPDATE' and we would have many locking conflicts
quoted_name = connection.quote_table_name(table_name)
subquery = ready_scope.limit(1).lock(true).select("id").to_sql
subquery = ready_scope.limit(1).lock('FOR UPDATE SKIP LOCKED').select("id").to_sql
sql = "UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery}) RETURNING *"
reserved = find_by_sql([sql, now, worker.name])
reserved[0]
Expand Down

0 comments on commit 5206912

Please sign in to comment.