-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support named parameter 'type' in the Cast attribute. #87
Support named parameter 'type' in the Cast attribute. #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Can you update one or two datasets to not use the named parameter just so we can have use cases validated against using and not using the named parameter, please?
8e207d8
to
ab7f9db
Compare
Changed, I was maybe a bit too eager in adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not related to the files you worked on, but can you run the linter to fix the issues with the code style, please? I think that's because of a new rule on a newer version from Pint 😅
Pint errors are fixed, now PHPStan is complaining 😅 |
😅 😅 😅 |
Fixed PHPStan errors as well! |
The tests were also failing for me locally, but never via Github actions, until now... |
Thanks for taking a look at it. I'll see if I have some time next week to check on the tests |
I fixed the tests by removing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all the effort in this PR! 💪
When using
#[Cast(type: 'int')]
for example, I always ran into the following exception: