Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add models GP-VAE/USGAN #176

Merged
merged 17 commits into from
Sep 21, 2023
Merged

add models GP-VAE/USGAN #176

merged 17 commits into from
Sep 21, 2023

Conversation

AugustJW
Copy link
Contributor

What does this PR do?

Fixing #175

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Aug 21, 2023

Pull Request Test Coverage Report for Build 5927686933

  • 143 of 649 (22.03%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-9.0%) to 74.337%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/base.py 0 1 0.0%
pypots/imputation/gpvae/data.py 10 30 33.33%
pypots/imputation/usgan/data.py 10 35 28.57%
pypots/imputation/usgan/modules.py 17 47 36.17%
pypots/imputation/gpvae/modules.py 24 125 19.2%
pypots/imputation/gpvae/model.py 29 152 19.08%
pypots/imputation/usgan/model.py 44 250 17.6%
Files with Coverage Reduction New Missed Lines %
pypots/forecasting/base.py 1 34.09%
Totals Coverage Status
Change from base Build 5916043036: -9.0%
Covered Lines: 3253
Relevant Lines: 4376

💛 - Coveralls

@WenjieDu WenjieDu self-requested a review August 21, 2023 16:06
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

This pull request had no activity for 14 days. It will be closed in 1 week unless there is some new activity.

@github-actions github-actions bot added the stale label Sep 5, 2023
@github-actions github-actions bot removed the stale label Sep 6, 2023
Copy link
Owner

@WenjieDu WenjieDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jun, thanks for your PR! Although this is your first PR on GitHub, I can see you're really trying to contribute something to PyPOTS and make it better. Nice job!

I'm going to validate and refactor your code to make us able to merge it.

@WenjieDu WenjieDu self-assigned this Sep 6, 2023
@github-actions github-actions bot added the stale label Sep 21, 2023
@WenjieDu WenjieDu added enhancement New feature or request new algo Proposing to add a new model/algorithm and removed stale labels Sep 21, 2023
Repository owner deleted a comment from github-actions bot Sep 21, 2023
@WenjieDu WenjieDu merged commit 9bfffa1 into WenjieDu:dev Sep 21, 2023
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new algo Proposing to add a new model/algorithm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants