Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding other options for the first step imputation in LOCF #240

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Adding other options for the first step imputation in LOCF #240

merged 2 commits into from
Nov 21, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

Fixing #236

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6940884607

  • 43 of 43 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 83.424%
Files with Coverage Reduction New Missed Lines %
pypots/classification/base.py 1 74.07%
pypots/base.py 2 70.55%
pypots/imputation/locf/model.py 3 93.33%
Totals Coverage Status
Change from base Build 6938017365: 0.02%
Covered Lines: 4439
Relevant Lines: 5321
💛 - Coveralls

@WenjieDu WenjieDu merged commit 58fd5ef into main Nov 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenjieDu @coveralls