Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to import torch_geometric only when init Raindrop #381

Merged
merged 3 commits into from
May 5, 2024

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented May 5, 2024

What does this PR do?

  1. fixing Only reminder missing torch_geometric when initializing Raindrop #380;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented May 5, 2024

Pull Request Test Coverage Report for Build 8959242419

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 8 (50.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 81.666%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/nn/modules/raindrop/backbone.py 4 6 66.67%
pypots/nn/modules/raindrop/layers.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pypots/nn/modules/fedformer/layers.py 2 44.2%
Totals Coverage Status
Change from base Build 8892490423: 0.009%
Covered Lines: 7813
Relevant Lines: 9567

💛 - Coveralls

@WenjieDu WenjieDu merged commit 7b2ea9b into dev May 5, 2024
8 checks passed
@WenjieDu WenjieDu deleted the (fix)check_pyg_when_init_raindrop branch May 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants