Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ModernTCN as an imputation model #502

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Conversation

WenjieDu
Copy link
Owner

@WenjieDu WenjieDu commented Sep 4, 2024

What does this PR do?

  1. fixing Add ModernTCN #399;

Before submitting

  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10695049434

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 266 of 348 (76.44%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 83.145%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/moderntcn/core.py 26 28 92.86%
pypots/imputation/moderntcn/model.py 60 63 95.24%
pypots/nn/modules/patchtst/layers.py 16 32 50.0%
pypots/nn/modules/moderntcn/backbone.py 61 79 77.22%
pypots/nn/modules/moderntcn/layers.py 89 132 67.42%
Files with Coverage Reduction New Missed Lines %
pypots/forecasting/csdi/model.py 1 85.29%
pypots/cli/doc.py 2 83.54%
Totals Coverage Status
Change from base Build 10679869169: -0.2%
Covered Lines: 11134
Relevant Lines: 13391

💛 - Coveralls

@WenjieDu WenjieDu merged commit 9fb0719 into dev Sep 4, 2024
9 checks passed
@WenjieDu WenjieDu deleted the (feat)add_moderntcn branch September 4, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants