Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: chunk memory reads by 4K to avoid segfault #215

Merged
merged 1 commit into from
Sep 6, 2021
Merged

virtualbox: chunk memory reads by 4K to avoid segfault #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/driver/virtualbox.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use fdp::{RegisterType, FDP};

use crate::api::params::DriverInitParams;
use crate::api::registers::{Registers, SegmentReg, SystemTableReg, X86Registers};
use crate::api::{DriverType, Introspectable};
use crate::api::{DriverType, Introspectable, PAGE_SIZE};

#[derive(Debug)]
pub struct VBox {
Expand Down Expand Up @@ -42,7 +42,11 @@ impl Introspectable for VBox {
buf: &mut [u8],
bytes_read: &mut u64,
) -> Result<(), Box<dyn Error>> {
self.fdp.read_physical_memory(paddr, buf)?;
for (i, chunk) in buf.chunks_mut(PAGE_SIZE as usize).enumerate() {
let offset = i * PAGE_SIZE as usize;
let cur_paddr = paddr + offset as u64;
self.fdp.read_physical_memory(cur_paddr, chunk)?;
}
*bytes_read = buf.len() as u64;
Ok(())
}
Expand Down