Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32 Testing Fails due to warnings as errors #32

Open
WesWedding opened this issue Feb 20, 2024 · 1 comment
Open

ESP32 Testing Fails due to warnings as errors #32

WesWedding opened this issue Feb 20, 2024 · 1 comment

Comments

@WesWedding
Copy link
Owner

Testing has been turned off explicitly on the ESP32 because it generates warnings that are treated as errors.

The warning is valid, though, the Easing library's virtual EasingBase does not have a destructor.
@WesWedding
Copy link
Owner Author

WesWedding commented Feb 20, 2024 •
edited
Loading

TDB: Fork and pull-request a fix to Easing library, and re-enable the ESP32 platform.

Currently this is low priority because there is no actual memory leak here; the Eases don't dynamically allocate anything and a missing destructor doesn't actually have a material side effect.

WesWedding added a commit that referenced this issue Feb 20, 2024
@WesWedding
Added: A new test that flexes the setEase() of a Tween.
373196f 
This should have been done a long time ago, is an obvious oversight.  Especially now in light of #32, where a theoretical (but not actual) memory leak could be triggered.
WesWedding added a commit that referenced this issue Feb 20, 2024
@WesWedding
Updated: Related to #32, turning off esp32.
9e60c07 
The warning is valid but dirupting test results.  There is no memory leak detected or possible in testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WesWedding