Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on extracting time support to st0603 module #114

Merged
merged 4 commits into from
Apr 30, 2020

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented Apr 25, 2020

Motivation and Context

This is a start on refactoring of common time stamp (ST0603) code into a separate module.
Relates to #97, but doesn't complete it.

Description

Pulls out the common code into a new module. This is pretty minimal at the moment, but does make more shared code.

Also added the "time status" byte from ST0603.5 section 7.4. We need this to drop into the ST0604 video timestamp (see #102). It also helped to get the test coverage up which made Coveralls happier after the migration to common code reduced the coverage numbers (same amount of tests, just less covered lines, so lower percentage?)

How Has This Been Tested?

Unit tests, with good coverage.
Ran the viewer application across a couple of test files - no problems noted.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bradh bradh marked this pull request as ready for review April 25, 2020 04:06
@wlfgang wlfgang merged commit b608f88 into WestRidgeSystems:develop Apr 30, 2020
@bradh bradh deleted the st0603 branch April 30, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants