Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st0602: initial implementation work (2.x branch) #337

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented Nov 28, 2021

Motivation and Context

ST 0602 is annotation metadata. This is an initial implementation that provides full read / write coverage. There viewer application support (not working yet for CGM or SVG) and a generator example (again, not complete for CGM or SVG)

More implementation and interoperability work is planned, but this is a good chunk of it, and future API should be "convenience" additions.

Also, MISB is planning some changes, and this is an experimental test-bed for my evaluation.

Description

Full parsing and generating of the universal set.

The design is a bit strange because ST 0602 has three "prefix" elements that have to occur.

How Has This Been Tested?

Generation / viewer. Unit tests.

No interoperability testing, but I'm working on that.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bradh bradh marked this pull request as draft November 28, 2021 02:12
@codecov-commenter
Copy link

Codecov Report

Merging #337 (15c263b) into 2.x (d1d84c5) will increase coverage by 0.29%.
The diff coverage is 99.08%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #337      +/-   ##
============================================
+ Coverage     89.91%   90.20%   +0.29%     
- Complexity     4854     5059     +205     
============================================
  Files           518      542      +24     
  Lines         13237    13675     +438     
  Branches       1248     1280      +32     
============================================
+ Hits          11902    12336     +434     
- Misses         1293     1296       +3     
- Partials         42       43       +1     
Flag Coverage Δ
unittests-api 98.77% <99.08%> (+0.01%) ⬆️
unittests-api-ffmpeg 15.78% <ø> (ø)
unittests-core 98.49% <ø> (ø)
unittests-geoid 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...api/klv/st0602/AnnotationMetadataUniversalSet.java 95.40% <95.40%> (ø)
.../src/main/java/org/jmisb/api/klv/KlvConstants.java 100.00% <100.00%> (ø)
...ain/java/org/jmisb/api/klv/MisbMessageFactory.java 100.00% <100.00%> (ø)
.../org/jmisb/api/klv/st0602/ActiveLinesPerFrame.java 100.00% <100.00%> (ø)
...isb/api/klv/st0602/ActiveLinesPerFrameMessage.java 100.00% <100.00%> (ø)
...org/jmisb/api/klv/st0602/ActiveSamplesPerLine.java 100.00% <100.00%> (ø)
...sb/api/klv/st0602/ActiveSamplesPerLineMessage.java 100.00% <100.00%> (ø)
...v/st0602/AnnotationActiveLinesPerFrameFactory.java 100.00% <100.00%> (ø)
.../st0602/AnnotationActiveSamplesPerLineFactory.java 100.00% <100.00%> (ø)
...isb/api/klv/st0602/AnnotationByteOrderFactory.java 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d84c5...15c263b. Read the comment docs.

@bradh bradh marked this pull request as ready for review November 28, 2021 05:18
@wlfgang wlfgang merged commit 282aaa5 into WestRidgeSystems:2.x Dec 10, 2021
@bradh bradh deleted the 2.x_st0602_merge branch December 10, 2021 21:48
@bradh bradh mentioned this pull request Dec 25, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants