Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve at most a single empty line between attributes #233

Closed
awalterschulze opened this issue Dec 10, 2020 · 0 comments · Fixed by #239
Closed

Preserve at most a single empty line between attributes #233

awalterschulze opened this issue Dec 10, 2020 · 0 comments · Fixed by #239
Labels
bug Something isn't working
Milestone

Comments

@awalterschulze
Copy link
Contributor

After receiving multiple issues with not preserving empty lines between attributes: from ifdef, ifdef with spec above, emulator args and trying to remove newlines between attributes with the same name, maybe these rules are becoming to complicated, here are links to some of the issues: #205 #95 #59 #178

erlfmt is an opinionated formatter, but at some points it has to leave some formatting up to the users.
We will stop removing an empty line between attributes like we have done before and we will stop adding an empty line between some attributes.

For example, this is not validly formatted code right now, but would be after we make this change.

-module(bla).
-define(DEFAULT_WIDTH, 100).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant