preserve a single empty line between attributes #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
awalterschulze
changed the title
awalterschulze
force-pushed
the
preserve_one_empty_line
branch
from
3172fdd to
271103c
Compare
michalmuskala
approved these changes
Jan 20, 2021
src/erlfmt_scan.erl
Outdated
| @@ -198,6 +221,7 @@ split_tokens(Tokens, ExtraTokens0) -> | |||
| {[], Comments} -> | |||
| {[], Tokens, Comments, ExtraTokens0}; | |||
| {TransformedTokens, Comments} -> | |||
| % io:format(user, "tokens: ~p~n", [Tokens]), | |||
There was a problem hiding this comment.
✂️
Suggested change
| % io:format(user, "tokens: ~p~n", [Tokens]), |
awalterschulze
force-pushed
the
preserve_one_empty_line
branch
from
271103c to
a95de00
Compare
awalterschulze
force-pushed
the
preserve_one_empty_line
branch
from
a95de00 to
3e958f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #233
Tests
erlfmt_SUITE_data/attribute.erlalready tests quite a few cases of preserving empty lines.Added one test to make sure that more than one empty line is reduced to a single empty line.