Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Consolidations feature with Pattern Replacement #1029

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

scottkleinman
Copy link
Contributor

This is a major change, replacing the old Consolidations feature with a new Pattern Replacement feature that implements a general pattern replacement function accepting regex patterns. It needs a review for UX and code efficiency. It probably also needs a unit test set up (volunteers?).

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #1029 into master will decrease coverage by 0.37%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   58.92%   58.54%   -0.38%     
==========================================
  Files          40       40              
  Lines        3175     3199      +24     
==========================================
+ Hits         1871     1873       +2     
- Misses       1304     1326      +22     
Impacted Files Coverage Δ
lexos/processors/prepare/scrubber.py 55.58% <3.22%> (-3.83%) ⬇️
lexos/helpers/constants.py 100.00% <100.00%> (ø)
lexos/helpers/error_messages.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f052641...113aab7. Read the comment docs.

@scottkleinman
Copy link
Contributor Author

The frontend refactor of the last couple of days will make it very hard to merge this branch into master. I recommend just using this branch to test for UX and optimisation. If it works, the changes can be re-created in a new branch based on the latest version of master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant